linux-kernel - RE: [PATCH 1/3] virtio_console:Merge struct buffer_token into struct port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Sep 2012 09:12:33 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Sjur BRENDELAND <sjur.brandeland@...ricsson.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Amit Shah <amit.shah@...hat.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"virtualization\@lists.linux-foundation.org" 
	<virtualization@...ts.linux-foundation.org>,
	"sjurbren\@gmail.com" <sjurbren@...il.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	"yrl.pp-manager.tt\@hitachi.com" <yrl.pp-manager.tt@...achi.com>
Subject: RE: [PATCH 1/3] virtio_console:Merge struct buffer_token into struct port_buffer

Sjur BRENDELAND <sjur.brandeland@...ricsson.com> writes:
>> This allocates one redundant sg entry when nrbuf > 0,
>> but I think it is OK. (just a comment)
>
> I did this on purpose for the sake of simplicity, but I can
> change this to something like:
> 	 alloc_size = sizeof(*buf) + sizeof(buf->sg) * max(nrbufs - 1, 1);

That's why we use [0] in the definition (a GCC extension).

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/