linux-kernel - RE: [PATCH v6] hashtable: introduce a small and naive hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Sep 2012 15:36:45 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Mathieu Desnoyers" <mathieu.desnoyers@...icios.com>,
	"Sasha Levin" <levinsasha928@...il.com>
Cc:	"Steven Rostedt" <rostedt@...dmis.org>,
	<torvalds@...ux-foundation.org>, <tj@...nel.org>,
	<akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
	<ebiederm@...ssion.com>, <neilb@...e.de>, <bfields@...ldses.org>,
	<ejt@...hat.com>, <snitzer@...hat.com>, <edumazet@...gle.com>,
	<josh@...htriplett.org>, <rmallon@...il.com>, <palves@...hat.com>
Subject: RE: [PATCH v6] hashtable: introduce a small and naive hashtable

> Moreover, if your thinking is that we do not need a static inline
> function replicated at every caller, maybe we should introduce a
> lib/hashtable.c that implements those 2 functions.

That was my thought...
Given their nature, I'd guess they aren't critical path.
Probably not worth adding an entire source file though.

With regard to 'inline', when I say it, I really mean it!
Unfortunately some people seem to just type it anyway (rather
like 'register' used to get used) - so the compilers start
ignoring the request.
At least some versions of gcc will usually inline static
functions that are only called once - but even then it can
change its mind for almost no reason.

	David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/