linux-kernel - Re: [PATCH 02/57] power: ab8500_bm: Don't clear the CCMuxOffset bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Sep 2012 20:42:50 -0700
From:	Anton Vorontsov <anton.vorontsov@...aro.org>
To:	mathieu.poirier@...aro.org
Cc:	linux-kernel@...r.kernel.org, dwmw2@...radead.org
Subject: Re: [PATCH 02/57] power: ab8500_bm: Don't clear the CCMuxOffset bit

On Tue, Sep 25, 2012 at 10:11:59AM -0600, mathieu.poirier@...aro.org wrote:
> From: Kalle Komierowski <karl.komierowski@...ricsson.com>
> 
> The CCMuxOffset bit is not kept set, this will force the columb counter
> of the AB8500 to use the measure offset calibration.
> This should increase the accuracy of the fuel gauge.
> 
> Signed-off-by: Kalle Komierowski <karl.komierowski@...ricsson.com>
> Signed-off-by: Marcus Cooper <marcus.xm.cooper@...ricsson.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> Reviewed-by: Jonas ABERG <jonas.aberg@...ricsson.com>
> ---
>  drivers/power/ab8500_fg.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
> index bf02225..af792a8 100644
> --- a/drivers/power/ab8500_fg.c
> +++ b/drivers/power/ab8500_fg.c
> @@ -485,8 +485,9 @@ static int ab8500_fg_coulomb_counter(struct ab8500_fg *di, bool enable)
>  		di->flags.fg_enabled = true;
>  	} else {
>  		/* Clear any pending read requests */
> -		ret = abx500_set_register_interruptible(di->dev,
> -			AB8500_GAS_GAUGE, AB8500_GASG_CC_CTRL_REG, 0);
> +		ret = abx500_mask_and_set_register_interruptible(di->dev,
> +			AB8500_GAS_GAUGE, AB8500_GASG_CC_CTRL_REG,
> +			(RESET_ACCU | READ_REQ), 0);
>  		if (ret)
>  			goto cc_err;
>  
> @@ -1404,8 +1405,7 @@ static void ab8500_fg_algorithm_discharging(struct ab8500_fg *di)
>  		sleep_time = di->bat->fg_params->init_timer;
>  
>  		/* Discard the first [x] seconds */
> -		if (di->init_cnt >
> -			di->bat->fg_params->init_discard_time) {
> +		if (di->init_cnt > di->bat->fg_params->init_discard_time) {

This change is OK, but it's cosmetic, and desires its own patch (you can
combine all cosmetic changes, which does not change the logic, into one
patch).

>  			ab8500_fg_calc_cap_discharge_voltage(di, true);
>  
>  			ab8500_fg_check_capacity_limits(di, true);
> -- 
> 1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/