lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Sep 2012 19:34:36 -0500 From: Daniel Santos <danielfsantos@....net> To: Josh Triplett <josh@...htriplett.org> CC: Daniel Santos <daniel.santos@...ox.com>, LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...ux.intel.com>, Andrea Arcangeli <aarcange@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Christopher Li <sparse@...isli.org>, David Daney <david.daney@...ium.com>, David Howells <dhowells@...hat.com>, Joe Perches <joe@...ches.com>, Konstantin Khlebnikov <khlebnikov@...nvz.org>, linux-sparse@...r.kernel.org, Michel Lespinasse <walken@...gle.com>, Paul Gortmaker <paul.gortmaker@...driver.com>, Pavel Pisa <pisa@....felk.cvut.cz>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Steven Rostedt <rostedt@...dmis.org> Subject: Re: [Bulk] Re: [PATCH 5/10] compiler{,-gcc4}.h: Remove duplicate macros On 09/28/2012 07:23 PM, Josh Triplett wrote: > On Fri, Sep 28, 2012 at 06:20:06PM -0500, Daniel Santos wrote: >> __linktime_error() does the same thing as __compiletime_error() and is >> only used in bug.h. Since the macro defines a function attribute that >> will cause a failure at compile-time (not link-time), it makes more >> sense to keep __compiletime_error(), which is also neatly mated with >> __compiletime_warning(). >> >> Signed-off-by: Daniel Santos <daniel.santos@...ox.com> > Why not change bug.h in the same commit? Or alternatively, why not > change it first? I'm still new to this project's development process and wasn't sure if those two changes would be considered lumping multiple changes together or not. So that type of lumping is acceptable then? I certainly wouldn't mind squashing them. > Getting rid of __linktime_error *before* changing its > use in bug.h to __compiletime_error seems wrong. Good point! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists