linux-kernel - Re: [RFC PATCH 1/2] kbuild: centralize .dts->.dtb rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Oct 2012 09:36:10 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
CC:	David Gibson <david@...son.dropbear.id.au>,
	Jon Loeliger <jdl@....com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Scott Wood <scottwood@...escale.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, Stephen Warren <swarren@...dia.com>
Subject: Re: [RFC PATCH 1/2] kbuild: centralize .dts->.dtb rule

On 09/29/2012 02:08 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:32 Fri 28 Sep     , Stephen Warren wrote:
>> From: Stephen Warren <swarren@...dia.com>
>>
>> All architectures that use cmd_dtc do so in the same way. Move the build
>> rule to a central location to avoid duplication.
>>
>> Signed-off-by: Stephen Warren <swarren@...dia.com>
>> ---
>> Jean-Christophe,
>> Moving the build rule to Makefile.lib rather than Makefile.build seems
>> reasonable to me; the dtc-related logic is already in Makefile.lib, and
>> for features where cmd_* is defined in Makefile.lib, the associated
>> build rule is also defined there. I see no reason for this patch series
>> to move all the dtc-related logic into Makefile.build.
> 
> build rules are in Makefile.build c to o , s to o etc...

As I explicitly pointed out above, your statement is simply not true;
there are many build rules in Makefile.lib.

> so put it in Makefile.build is the correct place ditto fot the dtc cmd

As such, I'm just going to ignore that feedback. Perhaps the kbuild
maintainer (oops, who I forgot to CC; I'll forward him the patches) can
weigh in though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/