linux-kernel - Re: [PATCH 03/17] ARM: pxa: Wunused-result warning in viper board file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Oct 2012 18:50:55 +0200
From:	Marc Zyngier <maz@...terjones.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	<linux-arm-kernel@...radead.org>, <arm@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Eric Miao <eric.y.miao@...il.com>
Subject: Re: [PATCH 03/17] ARM: pxa: Wunused-result warning in viper board file

On Tue,  2 Oct 2012 18:36:42 +0200, Arnd Bergmann <arnd@...db.de> wrote:
> Calling kstrtoul requires checking the result. In case of
> the viper_tpm_setup function, let's fail the __setup function
> if the number was invalid.
> 
> Without this patch, building viper_defconfig results in:
> 
> arch/arm/mach-pxa/viper.c: In function 'viper_tpm_setup':
> arch/arm/mach-pxa/viper.c:771:10: warning: ignoring return value of
> 'kstrtoul', declared with attribute warn_unused_result [-Wunused-result]
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Cc: Haojian Zhuang <haojian.zhuang@...il.com>
> Cc: Eric Miao <eric.y.miao@...il.com>
> Cc: Marc Zyngier <maz@...terjones.org>

Acked-by: Marc Zyngier <maz@...terjones.org>

> ---
>  arch/arm/mach-pxa/viper.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/viper.c b/arch/arm/mach-pxa/viper.c
> index 130379f..ac733e9 100644
> --- a/arch/arm/mach-pxa/viper.c
> +++ b/arch/arm/mach-pxa/viper.c
> @@ -768,8 +768,7 @@ static unsigned long viper_tpm;
>  
>  static int __init viper_tpm_setup(char *str)
>  {
> -	strict_strtoul(str, 10, &viper_tpm);
> -	return 1;
> +	return strict_strtoul(str, 10, &viper_tpm) >= 0;
>  }
>  
>  __setup("tpm=", viper_tpm_setup);

-- 
Who you jivin' with that Cosmik Debris?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/