linux-kernel - Re: [PATCH 2/5] mfd: tps65090: add error prints when mem alloc failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 07 Oct 2012 09:13:34 -0700
From:	Joe Perches <joe@...ches.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	vbyravarasu@...dia.com
Subject: Re: [PATCH 2/5] mfd: tps65090: add error prints when mem alloc
 failed

On Sun, 2012-10-07 at 20:52 +0530, Laxman Dewangan wrote:
> Add error prints when memory allocation failed for
> tps65090 data. Also cleanups the melloc arguments.

The new dev_err is unnecessary.
A dump_stack is already done on alloc failures.
The sizeof(* is ok.


> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
[]
> @@ -263,10 +263,11 @@ static int __devinit tps65090_i2c_probe(struct i2c_client *client,
>  		return -EINVAL;
>  	}
>  
> -	tps65090 = devm_kzalloc(&client->dev, sizeof(struct tps65090),
> -		GFP_KERNEL);
> -	if (tps65090 == NULL)
> +	tps65090 = devm_kzalloc(&client->dev, sizeof(*tps65090), GFP_KERNEL);
> +	if (!tps65090) {
> +		dev_err(&client->dev, "mem alloc for tps65090 failed\n");
>  		return -ENOMEM;
> +	}



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/