[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 10 Oct 2012 18:15:49 +0530
From: Sekhar Nori <nsekhar@...com>
To: Sekhar Nori <nsekhar@...com>
CC: Murali Karicheri <m-karicheri2@...com>, <khilman@...com>,
<davinci-linux-open-source@...ux.davincidsp.com>,
<mturquette@...aro.org>, <linux-c6x-dev@...ux-c6x.org>,
<arnd@...db.de>, <linus.walleij@...aro.org>,
<linux-kernel@...r.kernel.org>, <rob.herring@...xeda.com>,
<linux-keystone@...t.ti.com>, <viresh.linux@...il.com>,
<linux@....linux.org.uk>, <akpm@...ux-foundation.org>,
<shawn.guo@...aro.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 02/13] clk: davinci - add PSC clock driver
On 10/10/2012 6:05 PM, Sekhar Nori wrote:
>> +struct clk *clk_register_davinci_psc(struct device *dev, const char *name,
>> + const char *parent_name,
>> + struct clk_davinci_psc_data *psc_data,
>> + spinlock_t *lock)
>
> Why do you need the lock to be provided from outside of this file? You
> can initialize a lock for serializing writes to PSC registers within
> this file, no?
Looking again, it seems like the common clock framework defines an
"enable_lock" in drivers/clk/clk.c to serialize the clock enable/disable
calls. Unless I am missing something, this lock seems unnecessary.
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists