linux-kernel - Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 10 Oct 2012 10:55:31 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: Don't attempt to allocate zero bytes with
 vmalloc()

On Tue, Oct 09, 2012 at 10:55:17PM +0800, Ming Lei wrote:
> On Tue, Oct 9, 2012 at 8:36 PM, Mark Brown
> > On Tue, Oct 09, 2012 at 08:02:18PM +0800, Ming Lei wrote:

> > It doesn't really help as the ABI is such that you can only have one

> Could you let me know where the ABI is?

It's defined by firmware_class?

> > request_firmware() in play at once (unless this changed since I last
> > looked at it).

> I guess you mean that only one firmware device can be added
> as child of the device which is requesting firmware.

> The commit below(already merged into linus tree) should fix
> the problem:

>     99c2aa72306079976369aad7fc62cc71931d692a(firmware loader:
>     fix creation failure of fw loader device)

That's not been well advertised (and is extremely recent too)...

> Could you test it to see if more than one request_firmware_nowait()
> can be called concurrently for the same device?

Not for some time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/