linux-kernel - Re: [PATCH] usb: remove CONFIG_USB_MUSB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Oct 2012 12:06:08 +0200
From:	Constantine Shulyupin <const@...elinux.com>
To:	Sekhar Nori <nsekhar@...com>
Cc:	hs@...x.de, "Manjunathappa, Prakash" <prakash.pm@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Balbi, Felipe" <balbi@...com>,
	Sergei Shtylyov <sshtylyov@...sta.com>,
	Wolfgang Denk <wd@...x.de>
Subject: Re: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc

I've tested gadget mode on DM365 without HW changes.

On Thu, Oct 11, 2012 at 10:50 AM, Sekhar Nori <nsekhar@...com> wrote:
> On 10/11/2012 12:05 PM, Heiko Schocher wrote:
>> Hello Manjunathappa
>>
>> On 11.10.2012 07:42, Manjunathappa, Prakash wrote:
>>> Hi,
>>> On Mon, Oct 08, 2012 at 18:47:07, Constantine Shulyupin wrote:
>>>> From: Constantine Shulyupin<const@...eLinux.com>
>>>>
>>>> Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
>>>> CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST
>>>> and set MUSB_OTG configuration by default
>>>> because this configuration options are removed from Kconfig.
>>>>
>>>> Signed-off-by: Constantine Shulyupin<const@...eLinux.com>
>>>>
>>>> ---
>>>>   arch/arm/mach-davinci/usb.c |    6 ------
>>>>   1 file changed, 6 deletions(-)
>>>>
>>>> diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c
>>>> index f77b953..34509ff 100644
>>>> --- a/arch/arm/mach-davinci/usb.c
>>>> +++ b/arch/arm/mach-davinci/usb.c
>>>> @@ -42,14 +42,8 @@ static struct musb_hdrc_config musb_config = {
>>>>   };
>>>>
>>>>   static struct musb_hdrc_platform_data usb_data = {
>>>> -#if defined(CONFIG_USB_MUSB_OTG)
>>>>       /* OTG requires a Mini-AB connector */
>>>>       .mode           = MUSB_OTG,
>>>> -#elif defined(CONFIG_USB_MUSB_PERIPHERAL)
>>>> -    .mode           = MUSB_PERIPHERAL,
>>>> -#elif defined(CONFIG_USB_MUSB_HOST)
>>>> -    .mode           = MUSB_HOST,
>>>> -#endif
>>>>       .clock        = "usb",
>>>>       .config        =&musb_config,
>>>>   };
>>>
>>> Tested it on DM6446-EVM for host mode with MSC thumb drive and gadget
>>> mode with g-ether. It works.
>>>
>>> Acked-by: Manjunathappa, Prakash<prakash.pm@...com>
>>
>> I sent a similiar patch here:
>>
>> http://comments.gmane.org/gmane.linux.usb.general/54512
>>
>> If the issues, mentioned from Sergei for my patch, nullified I add my:
>
> The last outstanding issue from Sergei seems to be additional comments
> describing why MUSB_OTG is OK to use.
>
> Prakash/Constantine,
>
> Did you have to make any hardware changes when testing host/gadget on
> DM6446 EVM? Or change in kernel configuration?
>
> It appears that there is no way to choose any of the config option
> affecting the mode setting. Right now it seems to be just defaulting to
> MUSB_UNDEFINED. Setting it to MUSB_OTG would be better than that.
>
> Thanks,
> Sekhar



-- 
Constantine Shulyupin
http://www.MakeLinux.com/
Embedded Linux Systems,
Device Drivers, TI DaVinci
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/