linux-kernel - Re: [PATCH] Platform: hp-wmi: add rfkill support for integrated GPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Oct 2012 15:15:47 +0200
From:	Trepák Vilmos <trepo@...comga.sk>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Platform: hp-wmi: add rfkill support for integrated GPS

On Thu, 2012-10-11 at 13:34 +0100, Matthew Garrett wrote:
> On Thu, Oct 11, 2012 at 12:51:00PM +0200, Trepák Vilmos wrote:
> > @@ -663,6 +669,24 @@ static int __devinit hp_wmi_rfkill_setup
> >  			goto register_bluetooth_error;
> >  	}
> >  
> > +	if (wireless & 0x3) {
> > +		gps_rfkill = rfkill_alloc("hp-gps", &device->dev,
> > +						RFKILL_TYPE_GPS,
> > +						&hp_wmi_rfkill_ops,
> > +						(void *) HPWMI_GPS);
> 
> I don't think this bit is right - in this codepath, wireless is a mask, 
> so 0x3 would mean wifi and bluetooth, not gps. I'd expect gps to be 0x8.

And you'd expect right. Re-tested with 0x8, it works.

>  
> The rest looks good, though.
> 

Of course it does, it's just copy & paste & replace... I don't even
think I deserve credit for it.

Is it worth it to resubmit the patch for a 1-byte change or will you
just take care of it yourself? If it's easier for you, I'll resubmit.


-- 
Trepák Vilmos <trepo@...comga.sk>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/