linux-kernel - RE: [PATCH -next] staging: ramster: depends on NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Oct 2012 13:10:02 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Konrad Wilk <konrad.wilk@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org
Subject: RE: [PATCH -next] staging: ramster: depends on NET

> From: Randy Dunlap [mailto:rdunlap@...otime.net]
> Sent: Thursday, October 11, 2012 10:34 AM
> To: Stephen Rothwell
> Cc: linux-next@...r.kernel.org; linux-kernel@...r.kernel.org; Dan Magenheimer; Konrad Wilk; Greg
> Kroah-Hartman; devel@...verdev.osuosl.org
> Subject: [PATCH -next] staging: ramster: depends on NET
> 
> From: Randy Dunlap <rdunlap@...otime.net>
> 
> ramster uses network interfaces that are only present when
> CONFIG_NET is enabled, so it should depend on NET.

Yep, thanks for catching!

Acked-by: Dan Magenheimer <dan.magenheimer@...cle.com>
 
> Fixes these build errors:
> 
> drivers/built-in.o: In function `sc_kref_release':
> tcp.c:(.text+0x24b9af): undefined reference to `sock_release'
> drivers/built-in.o: In function `r2net_open_listening_sock':
> tcp.c:(.text+0x24ca2b): undefined reference to `sock_create'
> tcp.c:(.text+0x24cb91): undefined reference to `sock_release'
> drivers/built-in.o: In function `r2net_recv_tcp_msg':
> tcp.c:(.text+0x24cdbd): undefined reference to `sock_recvmsg'
> drivers/built-in.o: In function `r2net_send_tcp_msg':
> tcp.c:(.text+0x24d341): undefined reference to `sock_sendmsg'
> drivers/built-in.o: In function `r2net_start_connect':
> tcp.c:(.text+0x24d8fa): undefined reference to `sock_create'
> drivers/built-in.o: In function `r2net_shutdown_sc':
> tcp.c:(.text+0x24e30c): undefined reference to `kernel_sock_shutdown'
> drivers/built-in.o: In function `r2net_accept_one':
> tcp.c:(.text+0x24f392): undefined reference to `sock_create_lite'
> tcp.c:(.text+0x24f3c3): undefined reference to `sock_release'
> drivers/built-in.o: In function `r2net_stop_listening':
> (.text+0x250f63): undefined reference to `sock_release'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> Cc: dan.magenheimer@...cle.com
> Cc: konrad.wilk@...cle.com
> ---
>  drivers/staging/ramster/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20121011.orig/drivers/staging/ramster/Kconfig
> +++ linux-next-20121011/drivers/staging/ramster/Kconfig
> @@ -18,6 +18,7 @@ config ZCACHE2
>  config RAMSTER
>  	bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
>  	depends on CONFIGFS_FS=y && SYSFS=y && !HIGHMEM && ZCACHE2=y
> +	depends on NET
>  	# must ensure struct page is 8-byte aligned
>  	select HAVE_ALIGNED_STRUCT_PAGE if !64_BIT
>  	default n
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/