linux-kernel - Re: [PATCH v6 1/6] tracing,x86: Add a TSC trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Oct 2012 12:05:08 -0700
From:	David Sharp <dhsharp@...gle.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel@...r.kernel.org,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [PATCH v6 1/6] tracing,x86: Add a TSC trace_clock

On Fri, Oct 12, 2012 at 4:41 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Fri, 2012-10-12 at 07:05 +0200, Geert Uytterhoeven wrote:
>> On Fri, Oct 12, 2012 at 1:27 AM, David Sharp <dhsharp@...gle.com> wrote:
>> > +#include <asm-generic/trace_clock.h>
>>
>> Please use the Kbuild infrastructure ("generic-y += ..." in
>> arch/*/include/asm/Kbuild)
>> instead of adding wrappers around the asm-generic version.
>
> So that's how that's done. Learn something new everyday. Too bad the one
> file I checked (div64.h) doesn't seem to do it for ia64 and others.
>
> Can we please have someone clean up all the archs and remove any *.h
> wrappers and use the kbuild infrastructure instead. That way, when
> another developer goes to look at how this is done, they wont copy the
> wrong method again. (Maybe I'll just do it :-p)
>
> David,
>
> Can you just send an update of this one patch.

Will do. Thanks for the education, Geert. :)

d#
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/