linux-kernel - Re: [PATCH REGRESSION FIX] dw_dmac: make driver's endianness configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Oct 2012 10:31:50 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Hein Tibosch <hein_tibosch@...oo.es>
Cc:	Andy Shevchenko <andy.shevchenko@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	viresh kumar <viresh.kumar@...aro.org>,
	spear-devel <spear-devel@...t.st.com>,
	Hans-Christian Egtvedt <egtvedt@...fundet.no>,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"ludovic.desroches" <ludovic.desroches@...el.com>,
	Havard Skinnemoen <havard@...nnemoen.net>,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH REGRESSION FIX] dw_dmac: make driver's endianness
 configurable

On Mon, 2012-10-15 at 08:39 +0800, Hein Tibosch wrote: 
> Hi Andy,
> On 10/15/2012 4:08 AM, Andy Shevchenko wrote:
> > On Sun, Oct 14, 2012 at 10:54 AM, Hein Tibosch <hein_tibosch@...oo.es> wrote:
> >> From: Hein Tibosch <hein_tibosch@...oo.es>
> >>
> >> The dw_dmac was originally developed for avr32 to be used with the Synopsys
> >> DesignWare AHB DMA controller. Starting from 2.6.38, access to the device's i/o
> >> <snip>
> >>  #define dma_readl(dw, name) \
> >> -       readl(&(__dw_regs(dw)->name))
> >> +       dma_readl_native(&(__dw_regs(dw)->name))
> >>  #define dma_writel(dw, name, val) \
> >> -       writel((val), &(__dw_regs(dw)->name))
> >> +       dma_writel_native((val), &(__dw_regs(dw)->name))
> >>
> >>  #define channel_set_bit(dw, reg, mask) \
> >>         dma_writel(dw, reg, ((mask) << 8) | (mask))
> > Why did you not change this one?
> 
> Because "dma_writel" already calls "dma_writel_native"
Sure,
looks good for me.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/