linux-kernel - Re: [PATCH v2 3/5] memory-hotplug: auto offline page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Oct 2012 23:26:14 +0800
From:	Wen Congyang <wencongyang@...il.com>
To:	wency@...fujitsu.com
CC:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	rientjes@...gle.com, liuj97@...il.com, len.brown@...el.com,
	benh@...nel.crashing.org, paulus@...ba.org, minchan.kim@...il.com,
	akpm@...ux-foundation.org, kosaki.motohiro@...fujitsu.com,
	isimatu.yasuaki@...fujitsu.com, Christoph Lameter <cl@...ux.com>
Subject: Re: [PATCH v2 3/5] memory-hotplug: auto offline page_cgroup when
 onlining memory block failed

At 2012/10/17 20:08, wency@...fujitsu.com Wrote:
> From: Wen Congyang<wency@...fujitsu.com>
> 
> When a memory block is onlined, we will try allocate memory on that node
> to store page_cgroup. If onlining the memory block failed, we don't
> offline the page cgroup, and we have no chance to offline this page cgroup
> unless the memory block is onlined successfully again. It will cause
> that we can't hot-remove the memory device on that node, because some
> memory is used to store page cgroup. If onlining the memory block
> is failed, there is no need to stort page cgroup for this memory. So
> auto offline page_cgroup when onlining memory block failed.
> 
> CC: David Rientjes<rientjes@...gle.com>
> CC: Jiang Liu<liuj97@...il.com>
> CC: Len Brown<len.brown@...el.com>
> CC: Benjamin Herrenschmidt<benh@...nel.crashing.org>
> CC: Paul Mackerras<paulus@...ba.org>
> CC: Christoph Lameter<cl@...ux.com>
> Cc: Minchan Kim<minchan.kim@...il.com>
> CC: Andrew Morton<akpm@...ux-foundation.org>
> CC: KOSAKI Motohiro<kosaki.motohiro@...fujitsu.com>
> CC: Yasuaki Ishimatsu<isimatu.yasuaki@...fujitsu.com>
> Signed-off-by: Wen Congyang<wency@...fujitsu.com>

This patch has been acked by kosaki.
I forgot to add "Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>"


> ---
>   mm/page_cgroup.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
> index 5ddad0c..44db00e 100644
> --- a/mm/page_cgroup.c
> +++ b/mm/page_cgroup.c
> @@ -251,6 +251,9 @@ static int __meminit page_cgroup_callback(struct notifier_block *self,
>   				mn->nr_pages, mn->status_change_nid);
>   		break;
>   	case MEM_CANCEL_ONLINE:
> +		offline_page_cgroup(mn->start_pfn,
> +				mn->nr_pages, mn->status_change_nid);
> +		break;
>   	case MEM_GOING_OFFLINE:
>   		break;
>   	case MEM_ONLINE:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/