linux-kernel - Re: [PATCH] pinctrl: tegra: correct bank for pingroup and drv pingroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Oct 2012 09:48:16 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	linus.walleij@...aro.org
CC:	Pritesh Raithatha <praithatha@...dia.com>,
	linux-kernel@...r.kernel.org, swarren@...dia.com,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: tegra: correct bank for pingroup and drv pingroup

On 10/17/2012 12:21 AM, Pritesh Raithatha wrote:
> Signed-off-by: Pritesh Raithatha <praithatha@...dia.com>

(dropping stable from CC)

Acked-by: Stephen Warren <swarren@...dia.com>
Tested-by: Stephen Warren <swarren@...dia.com>

Linus, if you could add Cc: stable when you commit it, that'd be useful
too. Thanks.

I have no idea how I screwed this up so badly, or how it worked when
programming completely bogus registers!

Adding a patch description would be useful especially for stable. A
useful patch description might be:

The bank numbers in the pinctrl driver must match the bank numbers in
the device tree. Swap the bank numbers in the driver to ensure this.
While we're at it, rename the #defines used for the bank base addresses
so it's more obvious which is which, and add comments indicating which
correspond to which device tree bank.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/