lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 17 Oct 2012 21:35:06 +0200
From:	Philip Rakity <prakity@...dia.com>
To:	Sangho Yi <antiroot@...il.com>
CC:	"prakity@...vell.com" <prakity@...vell.com>,
	"aaron.lu@....com" <aaron.lu@....com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"ulf.hansson@...ricsson.com" <ulf.hansson@...ricsson.com>,
	"cjb@...top.org" <cjb@...top.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 1/3] drivers: mmc: core: sdio.c: fixed lines with > 80
 chars


On 17 Oct 2012, at 15:13, Sangho Yi <antiroot@...il.com> wrote:

> Fixed coding style warning cases for exceeding 80 chars per line on
> sdio.c.
> 
> Signed-off-by: Sangho Yi <antiroot@...il.com>
> ---
> drivers/mmc/core/sdio.c |    6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index 2273ce6..14326e8 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -47,7 +47,8 @@ static int sdio_read_fbr(struct sdio_func *func)
> 
> 	if (data == 0x0f) {
> 		ret = mmc_io_rw_direct(func->card, 0, 0,
> -			SDIO_FBR_BASE(func->num) + SDIO_FBR_STD_IF_EXT, 0, &data);
> +			SDIO_FBR_BASE(func->num) + SDIO_FBR_STD_IF_EXT,
> +			0, &data);
> 		if (ret)
> 			goto out;
> 	}
> @@ -619,7 +620,8 @@ static int mmc_sdio_init_card(struct mmc_host *host, u32 ocr,
> 		card->type = MMC_TYPE_SD_COMBO;
> 
> 		if (oldcard && (oldcard->type != MMC_TYPE_SD_COMBO ||
> -		    memcmp(card->raw_cid, oldcard->raw_cid, sizeof(card->raw_cid)) != 0)) {
> +			memcmp(card->raw_cid, oldcard->raw_cid,
> +			sizeof(card->raw_cid)) != 0)) {
could you ident the sizeof one more tab stop
> 			mmc_remove_card(card);
> 			return -ENOENT;
> 		}
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ