| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Oct 2012 03:01:12 -0400 From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> To: wency@...fujitsu.com Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, rientjes@...gle.com, liuj97@...il.com, len.brown@...el.com, benh@...nel.crashing.org, paulus@...ba.org, minchan.kim@...il.com, akpm@...ux-foundation.org, isimatu.yasuaki@...fujitsu.com Subject: Re: [PATCH v3 3/9] memory-hotplug: flush the work for the node when the node is offlined On Fri, Oct 19, 2012 at 2:46 AM, <wency@...fujitsu.com> wrote: > From: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com> > > If the node is onlined after it is offlined, we will clear the memory > to store the node's information. This structure contains struct work, > so we should flush work before the work's information is cleared. This explanation is incorrect. Even if you don't call memset(), you should call flush_work() at offline event. Because of, after offlinining, we shouldn't touch any node data. Alive workqueue violate this principle. And, hmmm... Wait. Usually workqueue shutdowning has two phase. 1) inhibit enqueue new work 2) flush work. Otherwise other cpus may enqueue new work after flush_work(). Where is (1)? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists