linux-kernel - Re: [PATCH] remove untouched code in kfifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Oct 2012 09:34:43 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	richard -rw- weinberger <richard.weinberger@...il.com>,
	Wei Yang <weiyang@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remove untouched code in kfifo_in

On Fri, 19 Oct 2012, Stefani Seibold wrote:

> > > In kfifo_in marco, one piece of code is arounded by if(0). This code in
> > > introduced by Stefani Seibold <stefani@...bold.net> to suppress a compiler
> > > warning. This warning is not there with the upgrade of gcc version.
> > >
> > > This patch just remove this code.
> > 
> > Are you sure?
> > This code fragment looks like a compiler bomb to detect type mismatch to me...
> 
> Yes, you are great! That was the reason why i made this peace of code.
> So don't remove it!

As even you, the author of the code, got confused by it for a while, 
adding an explanatory comment seems appropriate.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/