lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 21 Oct 2012 16:52:52 +0530 From: Adil Mujeeb <mujeeb.adil@...il.com> To: Pavel Machek <pavel@....cz> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 0/9] Staging: winbond: Fixed coding style issues Hi Pavel, On Sun, Oct 21, 2012 at 4:12 PM, Pavel Machek <pavel@....cz> wrote: > On Fri 2012-10-12 22:07:06, Adil Mujeeb wrote: >> >> winbond directory files have lots of coding style issues. The patch > set tries to remove *most* (if not all) of the coding style > issues. checkpatch.pl script is still complaining (like 80 characters > limit) but major part of the serious coding style issues have been > rectified. > > ACK on patches except 2 and 5. Plus if you could keep the printks, > that would be great. When the driver is debugged and in wide use, we > can remove them, but now they are useful... Thanks Pavel for acknowledgement. I removed printk's as Joe and Greg recommended to remove "tracing" type debug calls. Let me know if I need to resubmit the patch. Regards, Adil > > Thanks, > Pavel > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists