linux-kernel - Re: [PATCH v2] gpiolib: Refactor gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Oct 2012 09:15:28 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] gpiolib: Refactor gpio_export

On 23/10/12 09:13, Linus Walleij wrote:
> On Mon, Oct 22, 2012 at 2:39 AM, Ryan Mallon <rmallon@...il.com> wrote:
> 
>> The gpio_export function uses nested if statements and the status
>> variable to handle the failure cases. This makes the function logic
>> difficult to follow. Refactor the code to abort immediately on failure
>> using goto. This makes the code slightly longer, but significantly
>> reduces the nesting and number of split lines and makes the code easier
>> to read.
> 
> Splendid, patch applied!

Thanks.

>> Signed-off-by: Ryan Mallon
> 
> Interesting that you sign off without an email address, I just added it
> thinking it was a mistake.

Whoops. Yeah, should be:

  Signed-off-by: Ryan Mallon <rmallon@...il.com>

Thanks,
~Ryan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/