linux-kernel - Re: [PATCH 155/193] init: remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Oct 2012 12:17:23 -0500
From:	Serge Hallyn <serge.hallyn@...onical.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	linux-kernel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 155/193] init: remove CONFIG_EXPERIMENTAL

Quoting Kees Cook (keescook@...omium.org):
> On Wed, Oct 24, 2012 at 6:48 AM, Serge Hallyn
> <serge.hallyn@...onical.com> wrote:
> > Quoting Kees Cook (keescook@...omium.org):
> >> This config item has not carried much meaning for a while now and is
> >> almost always enabled by default. As agreed during the Linux kernel
> >> summit, remove it.
> >>
> >> CC: "Eric W. Biederman" <ebiederm@...ssion.com>
> >> CC: Serge Hallyn <serge.hallyn@...onical.com>
> >> CC: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> >> CC: Andrew Morton <akpm@...ux-foundation.org>
> >> CC: Frederic Weisbecker <fweisbec@...il.com>
> >> Signed-off-by: Kees Cook <keescook@...omium.org>
> >> ---
> >>  init/Kconfig |   23 ++++++++++-------------
> >>  1 file changed, 10 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/init/Kconfig b/init/Kconfig
> >> index 2bf7b83..4b65c1c 100644
> >> --- a/init/Kconfig
> >> +++ b/init/Kconfig
> >> @@ -220,7 +220,7 @@ config SYSVIPC_SYSCTL
> >>
> >>  config POSIX_MQUEUE
> >>       bool "POSIX Message Queues"
> >> -     depends on NET && EXPERIMENTAL
> >> +     depends on NET
> >>       ---help---
> >>         POSIX variant of message queues is a part of IPC. In POSIX message
> >>         queues every message has a priority which decides about succession
> >> @@ -366,7 +366,7 @@ config BSD_PROCESS_ACCT_V3
> >>         at <http://www.gnu.org/software/acct/>.
> >>
> >>  config TASKSTATS
> >> -     bool "Export task/process statistics through netlink (EXPERIMENTAL)"
> >> +     bool "Export task/process statistics through netlink"
> >
> > In these cases, should we keep the '(EXPERIMENTAL)' text since it is just
> > a hint to anyone running make menuconfig?  I think removing the 'depends on
> > EXPERIMENTAL's is fine, but cases we should leave it (or replace it) as
> > a textual hint, except in cases where we're sure that is no longer the case.
> 
> I covered this in the 000 intro email (https://lkml.org/lkml/2012/10/23/580):

intro email is an appreciated courtesy, but should not take the place of
info in the individual patch changelogs, especially as the intro emails
won't go into git history.

> Some patches remove "(EXPERIMENTAL)" from Kconfig titles when there was
> no "depends on EXPERIMENTAL". I've removed the cases of these where I

Hm, I was under the impression that taskstats are not quite trusted yet,
but I could be way out of date with that.

> know the maintainer intended it that way. I've left the others in case a
> "depends on EXPERIMENTAL" had been removed in the past and it had been
> accidentally forgotten in the title. If the title is correct as-is,
> just let me know, and I'll drop the patch from my series.
> 
> 
> So, if some of these need to be adjusted, I'm fine with that. I opted
> for aggressive removal in this first series.
> 
> -Kees
> 
> -- 
> Kees Cook
> Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/