linux-kernel - Re: [PATCH v2] Support Elan Touchscreen eKTF product.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Oct 2012 11:13:23 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Scott Liu <scott.liu@....com.tw>
Cc:	linux-input@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	Jesse <jesse@....com.tw>, Vincent Wang <vincent.wang@....com.tw>,
	Paul <paul.liang@....com.tw>
Subject: Re: [PATCH v2] Support Elan Touchscreen eKTF product.

Hi Scott,

On Wed, Oct 24, 2012 at 09:41:43AM +0800, Scott Liu wrote:
> This patch is for Elan eKTF Touchscreen product, I2C adpater module.
> 
> Signed-off-by: Scott Liu <scott.liu@....com.tw>
> ---
> 
> Hi,
>         v2 revision I have fixed some bug as your advise.
>         1. To target the mainline
>         2. No Android dependency
>         3. reuse those duplication code from Henrik's patchset.
>                 (input_mt_sync_frame()  / input_mt_get_slot_by_key())

Just a quick run through the code, so:

- please remove polling support, it is not useful in production;
- why do you need a separate probe work instead of doing what you
  need in elants_probe()
- it is not a good idea to register input device first and then
  allocating memory for MT handling.
- I do not understand why kfifo is needed
- please remove the rest of the custom threads
- you do not need to call input_mt_destroy_slots() explicitly
- use request_firmware() instead of special character device to upload
  firmware.
- please use standard kernel-doc markup.
- consider what attributes are there only for debugging and move them to
  debugfs.
- I find the use of enums in this driver quite unconventional, just
  standard #defines would probably be more straightforward.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/