lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Oct 2012 08:43:27 +0530 From: Vinod Koul <vkoul@...radead.org> To: Grant Likely <grant.likely@...retlab.ca> Cc: vinod.koul@...el.com, Matt Porter <mporter@...com>, Dan Williams <djbw@...com>, Chris Ball <cjb@...top.org>, Linux DaVinci Kernel List <davinci-linux-open-source@...ux.davincidsp.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux MMC List <linux-mmc@...r.kernel.org> Subject: Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps() On Tue, 2012-10-23 at 23:49 +0100, Grant Likely wrote: > > +enum dmaengine_apis { > > + DMAENGINE_MEMCPY = 0x0001, > > + DMAENGINE_XOR = 0x0002, > > + DMAENGINE_XOR_VAL = 0x0004, > > + DMAENGINE_PQ = 0x0008, > > + DMAENGINE_PQ_VAL = 0x0010, > > + DMAENGINE_MEMSET = 0x0020, > > + DMAENGINE_SLAVE = 0x0040, > > + DMAENGINE_CYCLIC = 0x0080, > > + DMAENGINE_INTERLEAVED = 0x0100, > > + DMAENGINE_SG = 0x0200, > > +}; > > Actually, one more comment. Why the new enum? Why can't the > dma_transaction_type enum be used directly along with dma_cap_mask_t? Some of the capabilities above are not there in dma_caps_t like DMA_SG. Also DMA_INTERRUPT and DMA_PRIVATE would not make much sense here. BUT would help to keep things simpler if have one definition which includes all. -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists