linux-kernel - Re: [PATCH] Staging: android: binder: Fixed multi-line strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Oct 2012 21:13:35 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Anmol Sarma <unmole.in@...il.com>
Cc:	devel@...verdev.osuosl.org, swetland@...gle.com, arve@...roid.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: binder: Fixed multi-line strings

On Tue, Oct 23, 2012 at 03:13:38PM +0530, Anmol Sarma wrote:
> >From 949ecac6fcd58ffa6d02f6761058dbcfb1c2ba42 Mon Sep 17 00:00:00 2001
> From: Anmol Sarma <unmole.in@...il.com>
> Date: Tue, 23 Oct 2012 13:47:14 +0530
> Subject: [PATCH] Staging: android: binder: Strings cleanup
> 
> Changed all user visible multi-line stings to single line.

No you didn't:

> @@ -420,12 +422,12 @@ static void binder_set_nice(long nice)
>  	}
>  	min_nice = 20 - current->signal->rlim[RLIMIT_NICE].rlim_cur;
>  	binder_debug(BINDER_DEBUG_PRIORITY_CAP,
> -		     "binder: %d: nice value %ld not allowed use "
> +		     "%d: nice value %ld not allowed use "
>  		     "%ld instead\n", current->pid, nice, min_nice);

That's a multi-line string :(

And you sent 2 copies of this patch, why?

Care to try again?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/