linux-kernel - Re: [PATCH v2] Enable A20 using KBC for some MSI laptops to fix S3 resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Oct 2012 10:17:37 +0200
From:	Ondrej Zary <linux@...nbow-software.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Enable A20 using KBC for some MSI laptops to fix S3 resume

On Wednesday 24 October 2012, H. Peter Anvin wrote:
> On 10/24/2012 02:16 PM, Ondrej Zary wrote:
> > Some MSI laptop BIOSes are broken - INT 15h code uses port 92h to enable
> > A20 line but resume code assumes that KBC was used.
> > The laptop will not resume from S3 otherwise but powers off after a while
> > and then powers on again stuck with a blank screen.
> >
> > Fix it by enabling A20 using KBC. Affected laptop list and DMI data are
> > from bug reports at Ubuntu Launchpad.
> >
> > Also add kernel parameter to easily activate this quirk on any system.
> >
> > Only compile tested. The original patch was tested with EX600 and PR200.
> >
> > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=12878
>
> Are we guaranteed that this executes *before* the keyboard driver
> initializes?  If not, this needs to use the i8042 interface in the input
> subsystem or at least acquire i8042_lock.
>
> 	-hpa

The code is called in:
start_kernel()->setup_arch()->acpi_boot_table_init()

I think that it's before any drivers are initialized.

-- 
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/