linux-kernel - Re: [PATCH] dt: add helper function to read u8 & u16 variables & arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Oct 2012 08:19:01 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	grant.likely@...retlab.ca, spear-devel@...t.st.com,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	andriy.shevchenko@...el.com
Subject: Re: [PATCH] dt: add helper function to read u8 & u16 variables &
 arrays

On 10/25/2012 02:03 AM, Viresh Kumar wrote:
> On 12 October 2012 23:31, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>> This adds following helper routines:
>> - of_property_read_u8_array()
>> - of_property_read_u16_array()
>> - of_property_read_u8()
>> - of_property_read_u16()
>>
>> First two actually share most of the code with of_property_read_u32_array(), so
>> the common part is taken out into a macro, which can be used by all three
>> *_array() routines.
> 
> Hi Rob,
> 
> Any comment here?

For some reason, this does not show up on the list either in my mail or
mail list archives, but it is in patchwork. Can you resend it please.

The main question I have is be32_to_cpup() the right thing to do. I
would expect byte arrays to not need endian conversion, but I haven't
looked at how '/bits/ x' data is stored.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/