linux-kernel - Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Oct 2012 01:19:47 +0400
From:	Max Filippov <jcmvbkbc@...il.com>
To:	James Hogan <james.hogan@...tec.com>
Cc:	Arnd Bergmann <arnd@...db.de>, Jonas Bonn <jonas@...thpole.se>,
	linux-arch@...r.kernel.org, linux@...ts.openrisc.net,
	linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-xtensa@...ux-xtensa.org, Chris Zankel <chris@...kel.net>,
	Mike Frysinger <vapier@...too.org>,
	Chen Liqin <liqin.chen@...plusct.com>,
	Lennox Wu <lennox.wu@...il.com>,
	Guan Xuetao <gxt@...c.pku.edu.cn>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include

On Tue, Oct 23, 2012 at 1:21 PM, James Hogan <james.hogan@...tec.com> wrote:
> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
> cacheflush.h being able to use I/O functions like readl and writel due
> to circular include dependencies. It doesn't appear as if anything from
> cacheflush.h is actually used by the generic io.h, so remove the
> include.

Acked-by: Max Filippov <jcmvbkbc@...il.com> for xtensa part.

> I've compile tested a defconfig compilation of blackfin, openrisc (which
> needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_*
> definitions), and xtensa.
>
> Other architectures which use asm-generic/io.h are score and unicore32,
> and looking at their io.h I don't see any obvious problems.
>
> Signed-off-by: James Hogan <james.hogan@...tec.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Jonas Bonn <jonas@...thpole.se>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: Mike Frysinger <vapier@...too.org>
> Cc: Chen Liqin <liqin.chen@...plusct.com>
> Cc: Lennox Wu <lennox.wu@...il.com>
> Cc: Guan Xuetao <gxt@...c.pku.edu.cn>
> ---
> Any compile testing of score and unicore32 anybody could provide would
> be great.
>
>  arch/openrisc/include/asm/io.h |    1 +
>  include/asm-generic/io.h       |    1 -
>  2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/openrisc/include/asm/io.h b/arch/openrisc/include/asm/io.h
> index 07f5299..7c69139 100644
> --- a/arch/openrisc/include/asm/io.h
> +++ b/arch/openrisc/include/asm/io.h
> @@ -30,6 +30,7 @@
>  #define PIO_MASK               0
>
>  #include <asm-generic/io.h>
> +#include <asm/pgtable.h>
>
>  extern void __iomem *__ioremap(phys_addr_t offset, unsigned long size,
>                                 pgprot_t prot);
> diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
> index 448303b..616eea5 100644
> --- a/include/asm-generic/io.h
> +++ b/include/asm-generic/io.h
> @@ -12,7 +12,6 @@
>  #define __ASM_GENERIC_IO_H
>
>  #include <asm/page.h> /* I/O is all done through memory accesses */
> -#include <asm/cacheflush.h>
>  #include <linux/types.h>
>
>  #ifdef CONFIG_GENERIC_IOMAP
> --
> 1.7.7.6
>
>



-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/