linux-kernel - Re: [PATCH 2/3] x86: ce4100: force reboot method to be KBD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Oct 2012 11:32:11 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Florian Fainelli <ffainelli@...ebox.fr>
Cc:	tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
	rui.zhang@...el.com, alan@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] x86: ce4100: force reboot method to be KBD


* Florian Fainelli <ffainelli@...ebox.fr> wrote:

> From: Maxime Bizon <mbizon@...ebox.fr>
> 
> The default reboot is via ACPI for this platform, and the CEFDK bootloader
> actually supports this, but will issue a system power off instead of a real
> reboot. Setting the reboot method to be KBD instead of ACPI ensures proper
> system reboot.
> 
> Signed-off-by: Florian Fainelli <ffainelli@...ebox.fr>
> ---
>  arch/x86/platform/ce4100/ce4100.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/platform/ce4100/ce4100.c b/arch/x86/platform/ce4100/ce4100.c
> index 74f8774..8c9ed9a 100644
> --- a/arch/x86/platform/ce4100/ce4100.c
> +++ b/arch/x86/platform/ce4100/ce4100.c
> @@ -21,6 +21,7 @@
>  #include <asm/i8259.h>
>  #include <asm/io.h>
>  #include <asm/io_apic.h>
> +#include <asm/emergency-restart.h>
>  
>  static int ce4100_i8042_detect(void)
>  {
> @@ -144,6 +145,8 @@ void __init x86_ce4100_early_setup(void)
>  	x86_init.mpparse.find_smp_config = x86_init_noop;
>  	x86_init.pci.init = ce4100_pci_init;
>  
> +	reboot_type = BOOT_KBD;

Here too put a minimal comment into the code:

	/*
	 * The system default is ACPI reboot, but that powers 
	 * off on CE4100 so the use KBD reset instead:
	 */
	reboot_type = BOOT_KBD;

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/