| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Oct 2012 09:03:18 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Alessandro Rubini <rubini@...dd.com> Cc: clouds.yan@...il.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32() On Sat, Oct 27, 2012 at 05:45:49PM +0200, Alessandro Rubini wrote: > >> This function is only used (twice) by the author of it, and the > >> 'prefix' feature is never used. > > I introduced it to shrink some internal code that had a lot of > repetition in the debugfs files implementation. In that context I use > the prefix string. Some of the code had later been submitted, but not > yet all of it. Later work by Davide Ciminaghi moved our MFD user to > the regmap interface, according to maintainer's suggestion (which > however means loosing register names from the debugfs dump). What is the status of the rest of that code getting accepted? > > If the parameter isn't being used, please, just delete it. > > It is not currently used by upstream callers, but the function itself > uses it as documented (Documentation/...). I wouldn't remove the > feature and introduce an incompatibility just for this. But if no one is using it, we can fix the documentation, and just drop it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists