lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Oct 2012 12:45:10 +0100 From: Jean Delvare <khali@...ux-fr.org> To: Joe Perches <joe@...ches.com> Cc: linux-kernel@...r.kernel.org, "Ben Dooks (embedded platforms)" <ben-linux@...ff.org>, "Wolfram Sang (embedded platforms)" <w.sang@...gutronix.de>, linux-i2c@...r.kernel.org Subject: Re: [PATCH 08/16] i2c: Convert dev_printk(KERN_<LEVEL> to dev_<level>( Hi Joe, On Sun, 28 Oct 2012 01:05:46 -0700, Joe Perches wrote: > dev_<level> calls take less code than dev_printk(KERN_<LEVEL> > and reducing object size is good. > Coalesce formats for easier grep. > > Signed-off-by: Joe Perches <joe@...ches.com> > --- > drivers/i2c/busses/i2c-piix4.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c > index 8bbd6ec..f7216ed 100644 > --- a/drivers/i2c/busses/i2c-piix4.c > +++ b/drivers/i2c/busses/i2c-piix4.c > @@ -204,9 +204,8 @@ static int __devinit piix4_setup(struct pci_dev *PIIX4_dev, > */ > pci_write_config_byte(PIIX4_dev, SMBHSTCFG, > temp | 1); > - dev_printk(KERN_NOTICE, &PIIX4_dev->dev, > - "WARNING: SMBus interface has been " > - "FORCEFULLY ENABLED!\n"); > + dev_notice(&PIIX4_dev->dev, > + "WARNING: SMBus interface has been FORCEFULLY ENABLED!\n"); > } else { > dev_err(&PIIX4_dev->dev, > "Host SMBus controller not enabled!\n"); Applied, thanks. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists