linux-kernel - Re: [ 102/105] usb: gadget: at91

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Oct 2012 07:21:37 +0100
From:	Fabio Porcedda <fabio.porcedda@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 102/105] usb: gadget: at91_udc: fix dt support

On Mon, Oct 29, 2012 at 12:17 AM, Ben Hutchings <ben@...adent.org.uk> wrote:
> 3.2-stable review patch.  If anyone has any objections, please let me know.

Hi Ben,
this patch is only useful only for kernel version 3.4 and later,
because the dt support was
introduced in the 3.4 release with the following commit:
     d1494a340807c9b77aa44bc8d8166353df4cf1c3
so i think it's best to doesn't apply this patch.

Best regards
-- 
Fabio Porcedda

> ------------------
>
> From: Fabio Porcedda <fabio.porcedda@...il.com>
>
> commit 9c6d196d5aa35e07482f23c3e37755e7a82140e0 upstream.
>
> Don't fail the initialization check for the platform_data
> if there is avaiable an associated device tree node.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@...il.com>
> Signed-off-by: Felipe Balbi <balbi@...com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>  drivers/usb/gadget/at91_udc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1735,7 +1735,7 @@ static int __devinit at91udc_probe(struc
>         int             retval;
>         struct resource *res;
>
> -       if (!dev->platform_data) {
> +       if (!dev->platform_data && !pdev->dev.of_node) {
>                 /* small (so we copy it) but critical! */
>                 DBG("missing platform_data\n");
>                 return -ENODEV;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/