linux-kernel - [PATCH] pwm: Device tree support for PWM polarity.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Oct 2012 23:10:27 +0530
From:	"Philip, Avinash" <avinashphilip@...com>
To:	<thierry.reding@...onic-design.de>, <grant.likely@...retlab.ca>,
	<rob.herring@...xeda.com>, <rob@...dley.net>
CC:	<linux-kernel@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>, <linux-doc@...r.kernel.org>,
	<nsekhar@...com>, <gururaja.hebbar@...com>,
	"Philip, Avinash" <avinashphilip@...com>
Subject: [PATCH] pwm: Device tree support for PWM polarity.

From: "Philip, Avinash" <avinashphilip@...com>

Adds support for 3rd cell in pwm-specifier. PWM polarity is encoded in
device tree support in bit encoded form. Platforms require polarity of
PWM device initialized during PWM device initialization has to encode
polarity in 3rd cell of pwm-specifier.

Signed-off-by: Philip, Avinash <avinashphilip@...com>
---
:100644 100644 73ec962... e522c59... M	Documentation/devicetree/bindings/pwm/pwm.txt
:100644 100644 f5acdaa... 1c6d50b... M	drivers/pwm/core.c
:100644 100644 112b314... d77c5b3... M	include/linux/pwm.h
 Documentation/devicetree/bindings/pwm/pwm.txt |   22 +++++++++++++++++++---
 drivers/pwm/core.c                            |   13 ++++++++++++-
 include/linux/pwm.h                           |    7 +++++++
 3 files changed, 38 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm.txt b/Documentation/devicetree/bindings/pwm/pwm.txt
index 73ec962..e522c59 100644
--- a/Documentation/devicetree/bindings/pwm/pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm.txt
@@ -37,10 +37,26 @@ device:
 		pwm-names = "backlight";
 	};
 
+Note that in the example above, specifying the "pwm-names" is redundant
+because the name "backlight" would be used as fallback anyway.
+
 pwm-specifier typically encodes the chip-relative PWM number and the PWM
-period in nanoseconds. Note that in the example above, specifying the
-"pwm-names" is redundant because the name "backlight" would be used as
-fallback anyway.
+period in nanoseconds.
+Optional pwm-specifier can be encoded in 3rd cell in bit encoded form.
+ -------------------------------------------------------------
+|     Property   |  BIT position | Encoding                   |
+|-------------------------------------------------------------|
+| Polarity       |   0           | Set   -> Polarity inversed |
+|                |               | Clear -> Polarity Normal   |
+ -------------------------------------------------------------
+
+Exapmple with optional PWM specifier for inversed polarity
+
+	bl: backlight {
+		pwms = <&pwm 0 5000000 1>;
+		pwm-names = "backlight";
+	};
+
 
 2) PWM controller nodes
 -----------------------
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index f5acdaa..1c6d50b 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -146,6 +146,15 @@ of_pwm_simple_xlate(struct pwm_chip *pc, const struct of_phandle_args *args)
 
 	pwm_set_period(pwm, args->args[1]);
 
+	if (pc->of_pwm_n_cells > 2) {
+		enum pwm_polarity polarity;
+
+		/* Initialize polarity of PWM device */
+		polarity = args->args[2] & POLARITY_BIT ?
+			PWM_POLARITY_INVERSED : PWM_POLARITY_NORMAL;
+		pwm_set_polarity(pwm, polarity);
+	}
+
 	return pwm;
 }
 
@@ -156,7 +165,9 @@ static void of_pwmchip_add(struct pwm_chip *chip)
 
 	if (!chip->of_xlate) {
 		chip->of_xlate = of_pwm_simple_xlate;
-		chip->of_pwm_n_cells = 2;
+
+		if (chip->of_pwm_n_cells != 3)
+			chip->of_pwm_n_cells = 2;
 	}
 
 	of_node_get(chip->dev->of_node);
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 112b314..d77c5b3 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -78,6 +78,13 @@ enum {
 	PWMF_ENABLED = 1 << 1,
 };
 
+/*
+ * DT Platform property support.
+ * POLARITY - set bit 0 in DT platform property
+ */
+
+#define POLARITY_BIT	BIT(0)
+
 struct pwm_device {
 	const char		*label;
 	unsigned long		flags;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/