lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Oct 2012 19:29:05 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: George Zhang <georgezhang@...are.com> Cc: linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, pv-drivers@...are.com Subject: Re: [PATCH 08/12] VMCI: resource object implementation. On Mon, Oct 29, 2012 at 06:04:58PM -0700, George Zhang wrote: > +static struct vmci_resource *vmci_resource_lookup(struct vmci_handle handle) > +{ > + struct vmci_resource *r, *resource = NULL; > + struct hlist_node *node; > + unsigned int idx = vmci_resource_hash(handle); > + > + BUG_ON(VMCI_HANDLE_EQUAL(handle, VMCI_INVALID_HANDLE)); You just crashed a machine, with no chance for recovery. Not a good idea. Never a good idea. Customers just lost data, and now they are mad. Make sure you at least print out your email address so they know who to blame :) Seriously, never BUG() in a driver, warn, sure, but this just looks like a debugging assert(). Please remove all of these, they are sprinkled all over the driver code here, I'm only responding to one of them here. Even better yet, properly handle the error and keep on going, that's what the rest of the kernel does. Or should :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists