| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Nov 2012 14:39:21 -0400 From: Nick Bowler <nbowler@...iptictech.com> To: Michal Simek <monstr@...str.eu> Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, arm@...nel.org, Arnd Bergmann <arnd@...db.de>, John Linn <john.linn@...inx.com>, Michal Simek <michal.simek@...inx.com>, Josh Cartwright <josh.cartwright@...com> Subject: Re: [PATCH v2] ARM: zynq: Allow UART1 to be used as DEBUG_LL console. On 2012-10-30 12:27 +0100, Michal Simek wrote: > On 10/29/2012 07:19 PM, Nick Bowler wrote: > > +#if IS_ENABLED(CONFIG_DEBUG_ZYNQ_UART1) > > +# define LL_UART_PADDR UART1_PHYS > > +# define LL_UART_VADDR UART_VIRT > > +#else > > +# define LL_UART_PADDR UART0_PHYS > > +# define LL_UART_VADDR UART_VIRT > > +#endif > > Probably no reason to setup LL_UART_VADDR on two lines. > It is enough to set it up once. > > MINOR: It is just my personal preference to use different coding style. > > #if IS_ENABLED(CONFIG_DEBUG_ZYNQ_UART1) > # define LL_UART_PADDR UART1_PHYS > #else > # define LL_UART_PADDR UART0_PHYS > #endif > > #define LL_UART_VADDR UART_VIRT I have no strong feeling either way, so I will send v3 with these changes. Thanks, -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists