linux-kernel - Re: [PATCH] pinctrl: PINCTRL_SAMSUNG and PINCTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 6 Nov 2012 10:03:43 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Kyungmin Park <kyungmin.park@...sung.com>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Tomasz Figa <t.figa@...sung.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: PINCTRL_SAMSUNG and PINCTRL_EXYNOS4 need to
 depend on OF && GPIOLIB

On Tue, Nov 6, 2012 at 8:04 AM, Axel Lin <axel.lin@...ics.com> wrote:

> This patch fixes below build error when !CONFIG_OF_GPIO.
>
>   CC      drivers/pinctrl/pinctrl-samsung.o
> drivers/pinctrl/pinctrl-samsung.c: In function 'samsung_pinctrl_parse_dt_pins':
> drivers/pinctrl/pinctrl-samsung.c:557:19: warning: unused variable 'prop' [-Wunused-variable]
> drivers/pinctrl/pinctrl-samsung.c: In function 'samsung_gpiolib_register':
> drivers/pinctrl/pinctrl-samsung.c:797:5: error: 'struct gpio_chip' has no member named 'of_node'
> make[2]: *** [drivers/pinctrl/pinctrl-samsung.o] Error 1
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> The samsung pinctrl driver supports only device tree enabled platforms.
> Thus make PINCTRL_SAMSUNG depend on OF && GPIOLIB.
>
> The reason to depend on GPIOLIB is CONFIG_OF_GPIO only available when GPIOLIB
> is selected.
> Since PINCTRL_EXYNOS4 select PINCTRL_SAMSUNG, thus also make PINCTRL_EXYNOS4
> depend on OF && GPIOLIB.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

This looks good (maybe it should depend on OF_GPIO but who cares).

Patch applied to my fixes branch after som patch -p1 < foo.patch
mockery.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/