lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Nov 2012 16:57:06 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: Glauber Costa <glommer@...allels.com> Cc: <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>, <kamezawa.hiroyu@...fujitsu.com>, Johannes Weiner <hannes@...xchg.org>, Tejun Heo <tj@...nel.org>, Michal Hocko <mhocko@...e.cz>, Christoph Lameter <cl@...ux.com>, Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>, Pekka Enberg <penberg@...helsinki.fi>, Suleiman Souhlal <suleiman@...gle.com> Subject: Re: [PATCH v6 26/29] Aggregate memcg cache values in slabinfo On Thu, 1 Nov 2012 16:07:42 +0400 Glauber Costa <glommer@...allels.com> wrote: > When we create caches in memcgs, we need to display their usage > information somewhere. We'll adopt a scheme similar to /proc/meminfo, > with aggregate totals shown in the global file, and per-group > information stored in the group itself. > > For the time being, only reads are allowed in the per-group cache. > > ... > > +#define for_each_memcg_cache_index(_idx) \ > + for ((_idx) = 0; i < memcg_limited_groups_array_size; (_idx)++) Use of this requires slab_mutex, yes? Please add a comment, and confirm that all callers do indeed hold the correct lock. We could add a mutex_is_locked() check to the macro perhaps, but this isn't the place to assume the presence of slab_mutex, so it gets messy. > > ... > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists