linux-kernel - Re: [PATCH 3/7] OMAPDSS: APPLY: Fix the usage of wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Nov 2012 13:31:20 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Chuansheng Liu <chuansheng.liu@...el.com>
CC:	<FlorianSchandinat@....de>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] OMAPDSS: APPLY: Fix the usage of wait_for_completion_timeout

On 2012-11-06 19:22, Chuansheng Liu wrote:
> 
> The return value of wait_for_completion_timeout() is always
>> = 0 with unsigned int type.
> 
> So the condition "ret < 0" or "ret >= 0" is pointless.
> 
> Signed-off-by: liu chuansheng <chuansheng.liu@...el.com>
> ---
>  drivers/video/omap2/dss/apply.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/apply.c b/drivers/video/omap2/dss/apply.c
> index 19d66f4..ec42a6a 100644
> --- a/drivers/video/omap2/dss/apply.c
> +++ b/drivers/video/omap2/dss/apply.c
> @@ -414,8 +414,6 @@ static void wait_pending_extra_info_updates(void)
>  	r = wait_for_completion_timeout(&extra_updated_completion, t);
>  	if (r == 0)
>  		DSSWARN("timeout in wait_pending_extra_info_updates\n");
> -	else if (r < 0)
> -		DSSERR("wait_pending_extra_info_updates failed: %d\n", r);
>  }
>  
>  int dss_mgr_wait_for_go(struct omap_overlay_manager *mgr)

Thanks. I'll apply this to omapdss tree to avoid any conflicts.

 Tomi





Download attachment "signature.asc" of type "application/pgp-signature" (898 bytes)