linux-kernel - Re: [PATCH] pinctrl: spear: Staticize non-exported symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Nov 2012 08:14:42 +0530
From:	viresh kumar <viresh.kumar@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, spear-devel <spear-devel@...t.st.com>
Subject: Re: [PATCH] pinctrl: spear: Staticize non-exported symbols

On Sun, Nov 11, 2012 at 7:59 AM, Axel Lin <axel.lin@...ics.com> wrote:
> They are not referenced outside of this file, make them static.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/pinctrl/spear/pinctrl-spear.c |   12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/spear/pinctrl-spear.c b/drivers/pinctrl/spear/pinctrl-spear.c
> index b1fd6ee..9a4dd4e 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear.c
> @@ -121,9 +121,10 @@ static void spear_pinctrl_pin_dbg_show(struct pinctrl_dev *pctldev,
>         seq_printf(s, " " DRIVER_NAME);
>  }
>
> -int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> -                                struct device_node *np_config,
> -                                struct pinctrl_map **map, unsigned *num_maps)
> +static int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> +                                       struct device_node *np_config,
> +                                       struct pinctrl_map **map,
> +                                       unsigned *num_maps)
>  {
>         struct spear_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>         struct device_node *np;
> @@ -168,8 +169,9 @@ int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
>         return 0;
>  }
>
> -void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
> -               struct pinctrl_map *map, unsigned num_maps)
> +static void spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
> +                                     struct pinctrl_map *map,
> +                                     unsigned num_maps)
>  {
>         kfree(map);
>  }

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/