| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Nov 2012 12:53:18 +1100 From: Dave Chinner <david@...morbit.com> To: Thiago Farina <tfransosi@...il.com> Cc: linux list <linux-kernel@...r.kernel.org>, Ben Myers <bpm@....com>, Alex Elder <elder@...nel.org>, xfs@....sgi.com Subject: Re: xfs: Remove boolean_t typedef completely. On Mon, Nov 12, 2012 at 10:36:47PM -0200, Thiago Farina wrote: > On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner <david@...morbit.com> wrote: > > On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote: > >> Hi, > >> > >> Please, take a look. > >> > >> Patch attached. > > > > It's a good start for a cleanup, but there's no point in removing > > the boolean_t from one file and then not removing it from the rest > > of the XFS code. It's only used in a handful of places, so just > > remove it completely. > > > Done. > > Please, take another look. > > > Also, can you please place patches in line rather than attaching > > them. Attaching them means they cannot be quoted in reply. See > > Documentation/SubmittingPatches and Documentation/email-clients.txt > > for guidelines. > > > Sorry, patch attached. It's still attached as a base64 encoded attachment, not as inline text.... Cheers, Dave. -- Dave Chinner david@...morbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists