linux-kernel - Re: xfs: Use bool type rather than a custom boolean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Nov 2012 11:24:20 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	linux list <linux-kernel@...r.kernel.org>, Ben Myers <bpm@....com>,
	Alex Elder <elder@...nel.org>, xfs@....sgi.com
Subject: Re: xfs: Use bool type rather than a custom boolean_t type.

On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote:
> Hi,
> 
> Please, take a look.
> 
> Patch attached.

It's a good start for a cleanup, but there's no point in removing
the boolean_t from one file and then not removing it from the rest
of the XFS code.  It's only used in a handful of places, so just
remove it completely.

Also, can you please place patches in line rather than attaching
them. Attaching them means they cannot be quoted in reply. See
Documentation/SubmittingPatches and Documentation/email-clients.txt
for guidelines.

Cheers,

Dave.

-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/