lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 14 Nov 2012 12:04:14 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"lrg@...com" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver

On Tue, Nov 13, 2012 at 10:01:26PM -0500, Laxman Dewangan wrote:

> >This does not seem sensible.  Why would this be optional if it is
> >useful?  In any case, what you're doing in the driver here is clearly
> >not the way forward.

> I was thinking  of adding wake_enable in struct regmap_irq_chip and
> decide the wake support based on the value if wake_enable true or
> wake_base is non-zero. then wake support should be enable.
> The wake register write will happen only when wake_base is non-zero.

But to repeat my question why would this be optional?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists