linux-kernel - Re: [PATCH v2] pstore/ram: fix undefined usage of rounddown_pow_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 17 Nov 2012 17:42:12 -0800
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	Florian Fainelli <ffainelli@...ebox.fr>, ccross@...roid.com,
	tony.luck@...el.com, linux-kernel@...r.kernel.org,
	Maxime Bizon <mbizon@...ebox.fr>, stable@...r.kernel.org
Subject: Re: [PATCH v2] pstore/ram: fix undefined usage of
 rounddown_pow_of_two(0)

On Mon, Oct 22, 2012 at 08:17:27AM -0700, Kees Cook wrote:
> On Mon, Oct 22, 2012 at 2:19 AM, Florian Fainelli <ffainelli@...ebox.fr> wrote:
> > From: Maxime Bizon <mbizon@...ebox.fr>
> >
> > record_size / console_size / ftrace_size can be 0 (this is how you
> > disable the feature), but rounddown_pow_of_two(0) is undefined. As suggested
> > by Kees Cook, use !is_power_of_2() as a condition to call rounddown_pow_of_two
> > and avoid its undefined behavior on the value 0. This issue has been present
> > since commit 1894a253 (ramoops: Move to fs/pstore/ram.c).
> >
> > CC: stable@...r.kernel.org
> > Signed-off-by: Maxime Bizon <mbizon@...ebox.fr>
> > Signed-off-by: Florian Fainelli <ffainelli@...ebox.fr>
> 
> Thanks for the fix!
> 
> Acked-by: Kees Cook <keescook@...omium.org>

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/