linux-kernel - Re: [PATCH] bug: Fix sparse warning related to BUILD_BUG_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 19 Nov 2012 15:40:06 +0400
From:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
To:	Tushar Behera <tushar.behera@...aro.org>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	patches@...aro.org
Subject: Re: [PATCH] bug: Fix sparse warning related to BUILD_BUG_ON_INVALID

Tushar Behera wrote:
> commit baf05aa9271b ("bug: introduce BUILD_BUG_ON_INVALID() macro")
> introduces this macro when only _CHECKER_ is defined. Define
> a silent macro in the else condition to fix following sparse
> warning.
>
> mm/filemap.c:395:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
> mm/filemap.c:396:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
> mm/filemap.c:397:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
> include/linux/mm.h:419:9: error: undefined identifier 'BUILD_BUG_ON_INVALID'
> include/linux/mm.h:419:9: error: not a function<noident>
>
> Signed-off-by: Tushar Behera<tushar.behera@...aro.org>

Thanks.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@...nvz.org>

> ---
>   include/linux/bug.h |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/bug.h b/include/linux/bug.h
> index aaac4bb..b1cf40d 100644
> --- a/include/linux/bug.h
> +++ b/include/linux/bug.h
> @@ -15,6 +15,7 @@ struct pt_regs;
>   #define BUILD_BUG_ON_NOT_POWER_OF_2(n)
>   #define BUILD_BUG_ON_ZERO(e) (0)
>   #define BUILD_BUG_ON_NULL(e) ((void*)0)
> +#define BUILD_BUG_ON_INVALID(e) (0)
>   #define BUILD_BUG_ON(condition)
>   #define BUILD_BUG() (0)
>   #else /* __CHECKER__ */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/