| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Nov 2012 00:01:45 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Lee Jones <lee.jones@...aro.org> Cc: sameo@...ux.intel.com, devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org, spear-devel@...t.st.com, Vipul Kumar Samar <vipulkumar.samar@...com> Subject: Re: [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver On 22 November 2012 16:54, Lee Jones <lee.jones@...aro.org> wrote: >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt b/Documentation/devicetree/bindings/mfd/stmpe.txt >> +Optional properties: >> +- irq-trigger: IRQ trigger to use for the interrupt to the host >> +- irq-invert-polarity: bool, IRQ line is connected with reversed polarity > > Are these new? > > When adding new bindings, ask yourself: I was trying to get information of these two bindings from other sources, but couldn't find. The only other place can be the interrupts field, right? Because interrupts field depends on the interrupt controller, which can be a wide variety of controllers in our case, we can't use that. Also, the cells of interrupts field will have something that is required to be programmed in the interrupt controller and not in the user of IC. But here we are talking about programming stmpe and so these bindings are very much required in stmpe only. Comments?? -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists