linux-kernel - Re: [PATCH v4 0/3] ACPI 5 support for GPIO, SPI and I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Nov 2012 22:31:15 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	grant.likely@...retlab.ca, linus.walleij@...aro.org,
	w.sang@...gutronix.de
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	rafael.j.wysocki@...el.com, linux-kernel@...r.kernel.org,
	lenb@...nel.org, broonie@...nsource.wolfsonmicro.com,
	khali@...ux-fr.org, ben-linux@...ff.org, bhelgaas@...gle.com,
	mathias.nyman@...ux.intel.com, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v4 0/3] ACPI 5 support for GPIO, SPI and I2C

On Tuesday, November 20, 2012 08:13:29 PM Mika Westerberg wrote:
> This is fourth version of the series. I've based these on top of Rafael's
> "simplify glueing ACPI handles to physical nodes" available from here:
> 
> 	https://lkml.org/lkml/2012/11/19/588
> 
> There is a dependency to linux-pm tree and to the above patches so I
> propose to merge these via that same tree. Subsystem maintainers, can you
> ack these if you think that they are a suitable shape?
> 
> Changes to v3:
> 	- simplify acpi_gpiochip_find()
> 	- acpi_spi/i2c_add_resource() uses acpi_dev_resource_interrupt()
> 	  directly instead of first checking the resource type
> 	- acpi_spi/i2c_add_device() calls acpi_dev_free_resource_list()
> 	  immediately after walking the resources and get rid of
> 	  fail_put_dev label.
> 
> Changes to v2:
> 	- drop the ACPI ->find_device() glue magic in preference of the new
> 	  simplified mechanism where we just assign the ACPI handle
> 	- correct the IRQ resource handling to take the first resource and
> 	  skip the rest
> 	- moved declaration of acpi_i2c_register_devices() to i2c.h instead
> 	  of having a separate header for a single function
> 
> Changes to the original version:
> 	[gpio]
> 	- CONFIG_GPIO_ACPI instead of CONFIG_ACPI_GPIO
> 	- removed redundant test in acpi_gpiochip_find()
> 
> 	[spi and i2c]
> 	- switched to use ACPI centralized _CRS evaluation framework
> 	  introduced by Rafael 
> 	- dropped request_module() call
> 	- dropped the acpi_enumerate_spi/i2c_device()
> 	- added required includes and dropped <linux/acpi.h> from
> 	  acpi_i2c.h
> 
> Thanks.
> 
> Mathias Nyman (1):
>   gpio / ACPI: add ACPI support
> 
> Mika Westerberg (2):
>   spi / ACPI: add ACPI enumeration support
>   i2c / ACPI: add ACPI enumeration support

This patchset has been around for quite a while and went through a few
iterations, so I think it's as good as it gets at this point.

I wonder if the GPIO / SPI / I2C maintainers have any objections against it or
would like the patches to be modified somehow?

If not, then I'd like to take it for v3.8 into the linux-pm.git tree, because
the patches depend on some changes already in that tree.  Hopefully, that's OK.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/