linux-kernel - Re: [PATCH RFT] mfd: rc5t583: Fix array subscript is above array bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 Nov 2012 03:03:25 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFT] mfd: rc5t583: Fix array subscript is above array
 bounds

On Tuesday 20 November 2012 08:04 AM, Axel Lin wrote:
> I got below build warning while compiling this driver.
> It's obviously RC5T583_MAX_INTERRUPT_MASK_REGS is 9 but irq_en_add array only
> has 8 elements.
>
>    CC      drivers/mfd/rc5t583-irq.o
> drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_sync_unlock':
> drivers/mfd/rc5t583-irq.c:227: warning: array subscript is above array bounds
> drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_init':
> drivers/mfd/rc5t583-irq.c:349: warning: array subscript is above array bounds
>
> Since the number of interrupt enable registers is 8, this patch adds define for
> RC5T583_MAX_INTERRUPT_EN_REGS to fix this bug.
>
> Signed-off-by: Axel Lin<axel.lin@...ics.com>
> ---
> Hi Laxman,
>    I don't have this hardware, I'd appreciate if you can review and test this patch.
> Thank you,
> Axel

This looks good. I dont see any issue on this.
I am planning to move this to regmap-irq, probably on next release.

Acked-by: Laxman Dewangan <ldewangan@...dia.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/