linux-kernel - Re: [PATCH] staging: line6: use kstrtoint() instead of simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 Nov 2012 00:52:44 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Laurent Navet [Mali]" <laurent.navet@...il.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	line6linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: line6: use kstrtoint() instead of
 simple_strtoul()

On Thu, Nov 29, 2012 at 09:03:38PM +0100, Laurent Navet [Mali] wrote:
> From: "Laurent Navet [Mali]" <laurent.navet@...il.com>
> 
> staging: line6: pcm.c
> 	call to obsolete simple_strtoul() function is replaced
>         by kstrtoint() in pcm_set_impulse_period().
> 	Also check the return code.
> 
> Signed-off-by: Laurent Navet [Mali] <laurent.navet@...il.com>
> ---
>  drivers/staging/line6/pcm.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
> index a0ce781..876ab89 100644
> --- a/drivers/staging/line6/pcm.c
> +++ b/drivers/staging/line6/pcm.c
> @@ -81,7 +81,13 @@ static ssize_t pcm_set_impulse_period(struct device *dev,
>  				      struct device_attribute *attr,
>  				      const char *buf, size_t count)
>  {
> -	dev2pcm(dev)->impulse_period = simple_strtoul(buf, NULL, 10);
> +        int value;
> +        int rv;

This uses spaces instead of tabs.  Run scripts/checkpatch.pl over
the patch before submitting.

Put a blank line here between the declarations and the code.

I see that you copied "rv" from the other places in the file and
generally matching the context is good, but in this case I think
"rv" is non-standard.  Normally we would use "ret" or "rc".

> +        rv = kstrtoint(buf, 10, &value);
> +        if (rv < 0)
> +		return rv;

Could you fix up those small details and resend?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/