linux-kernel - Re: [PATCH 5/5] arcmsr: Modify ARC-1214 IO Behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 Nov 2012 09:18:21 +0000
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	NickCheng <nick.cheng@...ca.com.tw>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	jejb@...nel.org
Subject: Re: [PATCH 5/5]  arcmsr: Modify ARC-1214 IO Behavior

On Fri, 2012-11-16 at 19:56 +0800, NickCheng wrote:
> From: Nick Cheng <nick.cheng@...ca.com.tw>
> 
> Modify ARC-1214 IO behavior to make up for HW seldom malfunction.
> Signed-off-by: Nick Cheng <nick.cheng@...ca.com.tw>

This still isn't right.  I said you could ignore most of the warnings
(like lines over 80 characters), but you have a lot of this:


> -			printk(KERN_NOTICE "arcmsr%d: memory mapping region fail \n", =
> acb->host->host_no);
> +			pr_notice("arcmsr%d: memory mapping"
> +				"region fail\n", acb->host->host_no);

I'm agnostic on whether you split a print, in spite of the warning but I
do tend to prefer longer lines, since they avoid the mistake you made
quite a few times, which is not leaving a space between the separate
words in the split string.  This will produce a message like

arcmsr1: memory mappingregion fail

Plus this indentation


> -		if (readl(&acb->pmuC->outbound_doorbell) & ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE) {
> -			writel(ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE_DOORBELL_CLEAR, &acb->pmuC->outbound_doorbell_clear);/*clear interrupt*/=0A=
> +		if (readl(&acb->pmuC->outbound_doorbell) &
> +			ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE) {
>    +		writel(ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE_DOORBELL_CLEAR,
> +				&acb->pmuC->outbound_doorbell_clear);

Is being changed from correctly indented to incorrectly indented (writel
needs another tab).

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/