linux-kernel - Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Dec 2012 09:43:08 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	czankel <chris@...kel.net>
CC:	Arnd Bergmann <arnd@...db.de>, Mark Salter <msalter@...hat.com>,
	Aurelien Jacquiot <a-jacquiot@...com>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Max Filippov <jcmvbkbc@...il.com>, linux-c6x-dev@...ux-c6x.org,
	linux-kernel@...r.kernel.org, linux-xtensa@...ux-xtensa.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu

On 12/03/2012 09:28 AM, czankel wrote:
> Thanks Lars, I have added it to the Xtensa for_next tree.
> 
> -Chris

Hi,

While the patch works standalone. It would be better if it'd go through the
same tree as the other patches in this series. Patch 1 removes the unused
vmlist field from the mm_context_t struct in asm-generic/mmu.h. So without that
patch this patch basically doubles the size of your mm_context_t.

- Lars

> 
> On 11/1/12 3:24 AM, Lars-Peter Clausen wrote:
>> The nommu portion of mmu.h of the extensa platform is basically the
>> same as the
>> asm-generic mmu.h. So use it instead.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
>>
>> ---
>> Note, due to lack of toolchain, etc this patch is completely untested.
>> ---
>>   arch/xtensa/include/asm/mmu.h   |    2 +-
>>   arch/xtensa/include/asm/nommu.h |    3 ---
>>   2 files changed, 1 insertions(+), 4 deletions(-)
>>   delete mode 100644 arch/xtensa/include/asm/nommu.h
>>
>> diff --git a/arch/xtensa/include/asm/mmu.h
>> b/arch/xtensa/include/asm/mmu.h
>> index 04890d6..8554b2c 100644
>> --- a/arch/xtensa/include/asm/mmu.h
>> +++ b/arch/xtensa/include/asm/mmu.h
>> @@ -12,7 +12,7 @@
>>   #define _XTENSA_MMU_H
>>     #ifndef CONFIG_MMU
>> -#include <asm/nommu.h>
>> +#include <asm-generic/mmu.h>
>>   #else
>>     /* Default "unsigned long" context */
>> diff --git a/arch/xtensa/include/asm/nommu.h
>> b/arch/xtensa/include/asm/nommu.h
>> deleted file mode 100644
>> index dce2c43..0000000
>> --- a/arch/xtensa/include/asm/nommu.h
>> +++ /dev/null
>> @@ -1,3 +0,0 @@
>> -typedef struct {
>> -    unsigned long end_brk;
>> -} mm_context_t;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/